Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlLiveReporter optional property for specifying a report save filepath #103

Merged
merged 1 commit into from
Sep 5, 2013

Conversation

KevM
Copy link
Collaborator

@KevM KevM commented Sep 4, 2013

I prefer to setup objects to have everything they need to do closer to they creation and then let them go.

  • renamed reportPath property to reportTemplateUrl
  • reportPath is now an optional Some(string) property where you can save the report
  • The reporter on quit will save the html to the directory and file specified.

I didn't like renaming the property but you are not 1.0 yet and I felt reportPath for a Url was confusing. I am open to not doing this.

@lefthandedgoat
Copy link
Owner

Ok should be good. You are right on the name and I just introduced that feature like 2-3 days ago. I can put a 'breaking' thing in patch notes, and notify the person who requested it. Hope to have a new build tonight.

lefthandedgoat added a commit that referenced this pull request Sep 5, 2013
HtmlLiveReporter optional property for specifying a report save filepath
@lefthandedgoat lefthandedgoat merged commit 0ad9382 into lefthandedgoat:master Sep 5, 2013
lefthandedgoat added a commit that referenced this pull request Sep 5, 2013
@lefthandedgoat
Copy link
Owner

This is now available on nuget, package 0.8.4

@KevM KevM deleted the htmlliveoutput branch September 5, 2013 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants